alamb commented on code in PR #1649: URL: https://github.com/apache/arrow-adbc/pull/1649#discussion_r1554551320
########## adbc.h: ########## @@ -459,6 +459,24 @@ const struct AdbcError* AdbcErrorFromArrayStream(struct ArrowArrayStream* stream /// /// \see AdbcConnectionGetInfo #define ADBC_INFO_VENDOR_ARROW_VERSION 2 +/// \brief Indicates whether SQL queries are supported (type: bool). +/// +/// \see AdbcConnectionGetInfo +#define ADBC_INFO_VENDOR_SQL 3 +/// \brief Indicates whether Substrait queries are supported (type: bool). +/// +/// \see AdbcConnectionGetInfo +#define ADBC_INFO_VENDOR_SUBSTRAIT 4 +/// \brief The minimum supported Substrait version, or null if +/// Substrait is not supported (type: utf8). Review Comment: Would using a type other than utf8 for a version make sense? The ADBC version appears to have a numeric encoding: ```c /// \since ADBC API revision 1.1.0 #define ADBC_VERSION_1_1_0 1001000 ``` ########## adbc.h: ########## @@ -459,6 +459,24 @@ const struct AdbcError* AdbcErrorFromArrayStream(struct ArrowArrayStream* stream /// /// \see AdbcConnectionGetInfo #define ADBC_INFO_VENDOR_ARROW_VERSION 2 +/// \brief Indicates whether SQL queries are supported (type: bool). Review Comment: Should we also make a new value for `ADBC_VERSION` ? `1.2.0` for example? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
