joellubi commented on code in PR #1649: URL: https://github.com/apache/arrow-adbc/pull/1649#discussion_r1553834678
########## adbc.h: ########## @@ -459,6 +459,28 @@ const struct AdbcError* AdbcErrorFromArrayStream(struct ArrowArrayStream* stream /// /// \see AdbcConnectionGetInfo #define ADBC_INFO_VENDOR_ARROW_VERSION 2 +/// \brief Indicates whether the driver connection is read only (type: bool). +/// +/// \see AdbcConnectionGetInfo +#define ADBC_INFO_VENDOR_READ_ONLY 3 Review Comment: I just pushed this change. It turns out that adbc.h already has `ADBC_CONNECTION_OPTION_READ_ONLY` defined, so I didn't need to add anything to options.h. Thanks for the review, it would've been a mistake to make this an info code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
