joellubi commented on code in PR #1649: URL: https://github.com/apache/arrow-adbc/pull/1649#discussion_r1558104113
########## adbc.h: ########## @@ -459,6 +459,24 @@ const struct AdbcError* AdbcErrorFromArrayStream(struct ArrowArrayStream* stream /// /// \see AdbcConnectionGetInfo #define ADBC_INFO_VENDOR_ARROW_VERSION 2 +/// \brief Indicates whether SQL queries are supported (type: bool). Review Comment: As I'm looking through the code now for references to the constant `ADBC_VERSION_1_1_0`, it does seem like a non-trivial amount of work to update the logic everywhere to account for `ADBC_VERSION_1_1_1`. Especially for such a minor and backward-compatible change, it doesn't seem worth it. Perhaps we could just do a comment / documentation update here to denote the minor version bump? Also, a refactor of ADBC version handling might be helpful going forward if it would simplify the logic for various feature gates that would allow us to bump versions more seamlessly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
