alamb commented on PR #9913: URL: https://github.com/apache/arrow-datafusion/pull/9913#issuecomment-2041039672
> > 🤔 it appears this PR has some sort of infinite loop -- I will investigate > > Thanks @alamb . Maybe because now we treat subqueries as additional children? I can also look into it later today or tomorrow... Thanks @peter-toth -- yes I think you are correct. I debugged a bit and I found that calling apply_subqueries cased infinite recursion. I removed the apply_subqueries call (see this https://github.com/peter-toth/arrow-datafusion/pull/3) but then some of the subquery plans don't work So now I am confused -- should `apply` visit all subquery `LogicalPlan`s or not? Maybe it does make sense, as you said above, to have separate `apply` and `apply_subquery` calls 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
