peter-toth commented on code in PR #9913:
URL: https://github.com/apache/arrow-datafusion/pull/9913#discussion_r1554646887
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -285,57 +287,57 @@ impl LogicalPlan {
/// Calls `f` on all expressions (non-recursively) in the current
/// logical plan node. This does not include expressions in any
/// children.
- pub fn inspect_expressions<F, E>(self: &LogicalPlan, mut f: F) ->
Result<(), E>
- where
- F: FnMut(&Expr) -> Result<(), E>,
- {
+ pub fn apply_expressions<F: FnMut(&Expr) -> Result<TreeNodeRecursion>>(
Review Comment:
Yes, we can do that. Let me file a new PR with this change tomorrow and then
look into the infinite recursion issue of this PR
(https://github.com/peter-toth/arrow-datafusion/pull/3). Until then I'm marking
this PR as draft.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
