alamb commented on code in PR #9913:
URL: https://github.com/apache/arrow-datafusion/pull/9913#discussion_r1555004546
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -285,57 +287,57 @@ impl LogicalPlan {
/// Calls `f` on all expressions (non-recursively) in the current
/// logical plan node. This does not include expressions in any
/// children.
- pub fn inspect_expressions<F, E>(self: &LogicalPlan, mut f: F) ->
Result<(), E>
- where
- F: FnMut(&Expr) -> Result<(), E>,
- {
+ pub fn apply_expressions<F: FnMut(&Expr) -> Result<TreeNodeRecursion>>(
Review Comment:
> I plan to check all .expressions() calls and see if it can be transformed
to the better .apply_expressions() once this PR is merged.
This would be good -- I think there are some more (though
https://github.com/apache/arrow-datafusion/pull/9974 did get merged)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
