alamb commented on code in PR #10050:
URL:
https://github.com/apache/arrow-datafusion/pull/10050#discussion_r1562964008
##########
datafusion/execution/src/config.rs:
##########
@@ -500,7 +500,7 @@ impl SessionConfig {
/// ```
///
/// [^1]: Compare that to [`ConfigOptions`] which only supports
[`ScalarValue`] payloads.
- pub fn with_extension<T>(mut self, ext: Arc<T>) -> Self
+ pub fn with_extension<T>(&mut self, ext: Arc<T>) -> &mut Self
Review Comment:
This is an API change and some people might like to be able to create a
`SessionConfig` with a builder style
I think we should add a new function for updating an existing
`SessionConfig` like this
```
pub fn set_extension<T>(&mut self, ext: Arc<T>) {
...
}
```
(ideally also with an example)
cc @milenkovicm as we also discussed various ways to make adding extensions
easier
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
