milenkovicm commented on code in PR #10050:
URL:
https://github.com/apache/arrow-datafusion/pull/10050#discussion_r1563183060
##########
datafusion/execution/src/config.rs:
##########
@@ -500,7 +500,7 @@ impl SessionConfig {
/// ```
///
/// [^1]: Compare that to [`ConfigOptions`] which only supports
[`ScalarValue`] payloads.
- pub fn with_extension<T>(mut self, ext: Arc<T>) -> Self
+ pub fn with_extension<T>(&mut self, ext: Arc<T>) -> &mut Self
Review Comment:
we talked about the other extensions
```rust
self.options_mut().extensions ...
```
which i always mix with this extensions 😀
I wonder if it make sense to register extension with internal mutability at
the session creation and mutate that extension from your optimizer/planner? 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
