MichaelScofield commented on code in PR #10050: URL: https://github.com/apache/arrow-datafusion/pull/10050#discussion_r1564759712
########## datafusion/execution/src/config.rs: ########## @@ -500,7 +500,7 @@ impl SessionConfig { /// ``` /// /// [^1]: Compare that to [`ConfigOptions`] which only supports [`ScalarValue`] payloads. - pub fn with_extension<T>(mut self, ext: Arc<T>) -> Self + pub fn with_extension<T>(&mut self, ext: Arc<T>) -> &mut Self Review Comment: @alamb I've changed the PR according to your suggestions, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org