tustvold commented on code in PR #5652:
URL: https://github.com/apache/arrow-rs/pull/5652#discussion_r1567374556
##########
object_store/src/azure/client.rs:
##########
@@ -306,27 +310,34 @@ impl AzureClient {
let content_id = format!("{part_idx:20}");
let block_id = BASE64_STANDARD.encode(&content_id);
- self.put_request(path, payload, Attributes::default())
+ self.put_request(path, payload)
.query(&[("comp", "block"), ("blockid", &block_id)])
- .set_idempotent(true)
+ .idempotent(true)
.send()
.await?;
Ok(PartId { content_id })
}
/// PUT a block list
<https://learn.microsoft.com/en-us/rest/api/storageservices/put-block-list>
- pub async fn put_block_list(&self, path: &Path, parts: Vec<PartId>) ->
Result<PutResult> {
+ pub async fn put_block_list(
+ &self,
+ path: &Path,
+ parts: Vec<PartId>,
+ opts: PutMultipartOpts,
+ ) -> Result<PutResult> {
let blocks = parts
.into_iter()
.map(|part| BlockId::from(part.content_id))
.collect();
let payload = BlockList { blocks }.to_xml().into();
let response = self
- .put_request(path, payload, Attributes::default())
+ .put_request(path, payload)
+ .with_attributes(opts.attributes)
+ .with_tags(opts.tags)
Review Comment:
Unlike AWS (and GCP which copies AWS) the tags and attributes are specified
in the completion request that assembles the object
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
