tustvold commented on code in PR #5652:
URL: https://github.com/apache/arrow-rs/pull/5652#discussion_r1567380842
##########
object_store/src/memory.rs:
##########
@@ -503,10 +509,11 @@ impl MultipartUpload for InMemoryUpload {
let mut buf = Vec::with_capacity(cap);
let parts = self.parts.iter().flatten();
parts.for_each(|x| buf.extend_from_slice(x));
- let etag = self
- .storage
- .write()
- .insert(&self.location, buf.into(), Attributes::new());
+ let etag = self.storage.write().insert(
+ &self.location,
+ buf.into(),
+ std::mem::take(&mut self.attributes),
Review Comment:
Calling complete multiple times is documented as implementation defined
behaviour so this is fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
