tustvold commented on code in PR #5652:
URL: https://github.com/apache/arrow-rs/pull/5652#discussion_r1567445663
##########
object_store/src/aws/client.rs:
##########
@@ -289,11 +286,79 @@ impl<'a> Request<'a> {
Self { builder, ..self }
}
- pub fn idempotent(mut self, idempotent: bool) -> Self {
- self.idempotent = idempotent;
+ pub fn headers(self, headers: HeaderMap) -> Self {
+ let builder = self.builder.headers(headers);
+ Self { builder, ..self }
+ }
+
+ pub fn idempotent(self, idempotent: bool) -> Self {
+ Self { idempotent, ..self }
+ }
+
+ pub fn with_encryption_headers(self) -> Self {
+ let headers = self.config.encryption_headers.clone().into();
+ let builder = self.builder.headers(headers);
+ Self { builder, ..self }
+ }
+
+ pub fn with_session_creds(self, use_session_creds: bool) -> Self {
+ Self {
+ use_session_creds,
+ ..self
+ }
+ }
+
+ pub fn with_tags(mut self, tags: TagSet) -> Self {
+ let tags = tags.encoded();
+ if !tags.is_empty() && !self.config.disable_tagging {
+ self.builder = self.builder.header(&TAGS_HEADER, tags);
+ }
self
}
+ pub fn with_attributes(self, attributes: Attributes) -> Self {
+ let mut has_content_type = false;
+ let mut builder = self.builder;
+ for (k, v) in &attributes {
+ builder = match k {
+ Attribute::CacheControl => builder.header(CACHE_CONTROL,
v.as_ref()),
+ Attribute::ContentType => {
+ has_content_type = true;
+ builder.header(CONTENT_TYPE, v.as_ref())
+ }
+ };
+ }
+
+ if !has_content_type {
+ if let Some(value) =
self.config.client_options.get_content_type(self.path) {
+ builder = builder.header(CONTENT_TYPE, value);
+ }
+ }
+ Self { builder, ..self }
+ }
+
+ pub fn with_payload(self, payload: PutPayload) -> Self {
+ let mut builder = self.builder;
+
+ let mut sha256 = Context::new(&digest::SHA256);
+ payload.iter().for_each(|x| sha256.update(x));
Review Comment:
This was a bug :sweat_smile:
We need to calculate this here for request signing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
