mapleFU commented on code in PR #41232:
URL: https://github.com/apache/arrow/pull/41232#discussion_r1567481048
##########
cpp/src/arrow/filesystem/gcsfs.cc:
##########
@@ -200,6 +201,16 @@ class GcsOutputStream : public arrow::io::OutputStream {
return internal::ToArrowStatus(stream_.last_status());
}
+ Future<> CloseAsync() override {
+ if (closed_) return Status::OK();
+
+ auto self = std::dynamic_pointer_cast<GcsOutputStream>(shared_from_this());
+ auto deferred = [self = std::move(self)]() -> Status { return
self->Close(); };
Review Comment:
Seems close would call this:
https://github.com/googleapis/google-cloud-cpp/blob/230f9f929ce85e0dfb045d5f1ee0df74cedbd204/google/cloud/storage/object_write_stream.cc#L85
Which is worth doing this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
