mapleFU commented on code in PR #41232:
URL: https://github.com/apache/arrow/pull/41232#discussion_r1567827403
##########
cpp/src/arrow/filesystem/gcsfs.cc:
##########
@@ -233,6 +244,7 @@ class GcsOutputStream : public arrow::io::OutputStream {
private:
gcs::ObjectWriteStream stream_;
+ const io::IOContext io_context_;
Review Comment:
> since the context might have indirect references to `stream_`
When would this happens?
##########
cpp/src/arrow/filesystem/gcsfs.cc:
##########
@@ -233,6 +244,7 @@ class GcsOutputStream : public arrow::io::OutputStream {
private:
gcs::ObjectWriteStream stream_;
+ const io::IOContext io_context_;
Review Comment:
> since the context might have indirect references to `stream_`
When would this happens?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]