mapleFU commented on code in PR #41232:
URL: https://github.com/apache/arrow/pull/41232#discussion_r1567818297
##########
cpp/src/arrow/filesystem/gcsfs.cc:
##########
@@ -200,6 +201,16 @@ class GcsOutputStream : public arrow::io::OutputStream {
return internal::ToArrowStatus(stream_.last_status());
}
+ Future<> CloseAsync() override {
+ if (closed_) return Status::OK();
+
+ auto self = std::dynamic_pointer_cast<GcsOutputStream>(shared_from_this());
Review Comment:
```
class ARROW_EXPORT OutputStream : virtual public FileInterface, public
Writable {
protected:
OutputStream() = default;
};
```
The `shared_from_this` is in `FileInterface`. I think we cannot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
