Omega359 commented on code in PR #10098:
URL:
https://github.com/apache/arrow-datafusion/pull/10098#discussion_r1567609664
##########
datafusion/proto/src/physical_plan/from_proto.rs:
##########
@@ -340,24 +339,10 @@ pub fn parse_physical_expr(
convert_required!(e.arrow_type)?,
)),
ExprType::ScalarFunction(e) => {
- let scalar_function =
- protobuf::ScalarFunction::try_from(e.fun).map_err(|_| {
- proto_error(
- format!("Received an unknown scalar function: {}",
e.fun,),
- )
- })?;
-
- let args = parse_physical_exprs(&e.args, registry, input_schema,
codec)?;
-
- // TODO Do not create new the ExecutionProps
- let execution_props = ExecutionProps::new();
-
- functions::create_builtin_physical_expr(
- &(&scalar_function).into(),
- &args,
- input_schema,
- &execution_props,
- )?
+ return Err(proto_error(format!(
Review Comment:
Since the only value left for ScalarFunction in the datafusion.proto is
'unknown' this implementation seemed reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
