Omega359 commented on code in PR #10098:
URL:
https://github.com/apache/arrow-datafusion/pull/10098#discussion_r1569374404
##########
datafusion/expr/src/expr.rs:
##########
@@ -1276,7 +1260,7 @@ impl Expr {
pub fn short_circuits(&self) -> bool {
match self {
Expr::ScalarFunction(ScalarFunction { func_def, .. }) => {
- matches!(func_def, ScalarFunctionDefinition::BuiltIn(fun) if
*fun == BuiltinScalarFunction::Coalesce)
+ matches!(func_def, ScalarFunctionDefinition::UDF(fun) if
fun.name().eq("coalesce"))
Review Comment:
I thought about that and my thought was that if that was done it would
replace the existing coalesce function and one would think it would (hopefully)
have similar functionality. If there is another way to determine it here it
should be a reasonable change. Just importing the crate though it's possible as
best as I can tell because that would cause a circular dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
