Omega359 commented on code in PR #10098:
URL:
https://github.com/apache/arrow-datafusion/pull/10098#discussion_r1571032080
##########
datafusion/expr/src/expr.rs:
##########
@@ -1276,7 +1260,7 @@ impl Expr {
pub fn short_circuits(&self) -> bool {
match self {
Expr::ScalarFunction(ScalarFunction { func_def, .. }) => {
- matches!(func_def, ScalarFunctionDefinition::BuiltIn(fun) if
*fun == BuiltinScalarFunction::Coalesce)
+ matches!(func_def, ScalarFunctionDefinition::UDF(fun) if
fun.name().eq("coalesce"))
Review Comment:
That is an option but I think if we go that route it should be it's own PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
