ZhangHuiGui commented on code in PR #41352:
URL: https://github.com/apache/arrow/pull/41352#discussion_r1580350907
##########
cpp/src/arrow/compute/row/grouper.cc:
##########
@@ -595,7 +598,13 @@ struct GrouperFastImpl : public Grouper {
return std::move(impl);
}
- ~GrouperFastImpl() { map_.cleanup(); }
+ Status Reset() override {
+ rows_.Clean();
+ rows_minibatch_.Clean();
+ map_.cleanup();
+ RETURN_NOT_OK(map_.init(encode_ctx_.hardware_flags, ctx_->memory_pool()));
+ return Status::OK();
Review Comment:
Do you think we should enlarge the size of the `temp_stack_`? Or the stack's
internal states like `top_` may no enough for the next bunch of operations
after grouper reset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
