jonkeane commented on code in PR #41403:
URL: https://github.com/apache/arrow/pull/41403#discussion_r1582198027
##########
ci/scripts/r_test.sh:
##########
@@ -46,7 +46,12 @@ if [ "$ARROW_USE_PKG_CONFIG" != "false" ]; then
export LD_LIBRARY_PATH=${ARROW_HOME}/lib:${LD_LIBRARY_PATH}
export R_LD_LIBRARY_PATH=${LD_LIBRARY_PATH}
fi
-export _R_CHECK_COMPILATION_FLAGS_KNOWN_=${ARROW_R_CXXFLAGS}
+
+export _R_CHECK_COMPILATION_FLAGS_KNOWN_="${_R_CHECK_COMPILATION_FLAGS_KNOWN_}
${ARROW_R_CXXFLAGS}"
+# These should generally be picked up, but are slightly wrong in rhub's
containers it appears
+# https://github.com/r-hub/containers/pull/63
+export _R_CHECK_COMPILATION_FLAGS_KNOWN_="${_R_CHECK_COMPILATION_FLAGS_KNOWN_}
-Wno-parentheses -Werror=format-security -Wp,-D_FORTIFY_SOURCE=3"
Review Comment:
I'm not 100% certain, but it seems good for us to append our flags to what's
already in this var in case it's there.
Lines 51-52 are a workaround for what I believe is an rhub issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
