jonkeane commented on code in PR #41403:
URL: https://github.com/apache/arrow/pull/41403#discussion_r1582199119
##########
r/tests/testthat/test-dplyr-funcs-datetime.R:
##########
@@ -291,7 +291,9 @@ test_that("timestamp round trip correctly via strftime and
strptime", {
# Some formats are not supported on Windows
if (!tolower(Sys.info()[["sysname"]]) == "windows") {
- formats <- c(formats, "%a", "%A", "%b", "%B", "%OS", "%I%p", "%r", "%T%z")
+ # "%r" could also be here, though it is only valid in some locales (those
+ # that use 12 hour formats, so skip for now)
+ formats <- c(formats, "%a", "%A", "%b", "%B", "%OS", "%I%p", "%T%z")
Review Comment:
This bit me because of the locale used by rhub/containers. But it's good for
us to know and not testing `%r` seems like a good balance to me. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
