jonkeane commented on code in PR #41403:
URL: https://github.com/apache/arrow/pull/41403#discussion_r1582245207
##########
dev/tasks/r/github.packages.yml:
##########
@@ -227,7 +227,7 @@ jobs:
working-directory: 'arrow'
extra-packages: cpp11
- name: Set CRAN like openssl
- if: contains(matrix.platform.runs_on, 'arm64')
+ if: contains(matrix.platform.name, 'arm64')
Review Comment:
I noticed both here and on main these jobs were [complaining about finding
ssl](https://github.com/ursacomputing/crossbow/actions/runs/8866315145/job/24343853963#step:16:127)
And it looks like this might be a typo here, I traced it back to #37684 where
`runs_on` was split into `name` and `runs_on`. If I'm reading correctly what
was here would never have run.
I'm not sure how this was passing prior to the recent binary instability
(and the windows failure mask when this ssl failure _started_). But this [seems
to
work](https://github.com/ursacomputing/crossbow/actions/runs/8868937137/job/24349295020)
though the upload step
[failed](https://github.com/ursacomputing/crossbow/actions/runs/8868937137/job/24349386706#step:11:72)
@assignUser (1) does this change look ok and (2) do you know what's up with
the upload error?
##########
dev/tasks/r/github.packages.yml:
##########
@@ -227,7 +227,7 @@ jobs:
working-directory: 'arrow'
extra-packages: cpp11
- name: Set CRAN like openssl
- if: contains(matrix.platform.runs_on, 'arm64')
+ if: contains(matrix.platform.name, 'arm64')
Review Comment:
I noticed both here and on main these jobs were [complaining about finding
ssl](https://github.com/ursacomputing/crossbow/actions/runs/8866315145/job/24343853963#step:16:127)
And it looks like this might be a typo here, I traced it back to #37684 where
`runs_on` was split into `name` and `runs_on`. If I'm reading correctly what
was here would never have run.
I'm not sure how this was passing prior to the recent binary instability
(and the windows failure mask when this ssl failure _started_). But this [seems
to
work](https://github.com/ursacomputing/crossbow/actions/runs/8868937137/job/24349295020)
though the upload step
[failed](https://github.com/ursacomputing/crossbow/actions/runs/8868937137/job/24349386706#step:11:72).
@assignUser (1) does this change look ok and (2) do you know what's up with
the upload error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
