zeroshade commented on code in PR #40807:
URL: https://github.com/apache/arrow/pull/40807#discussion_r1583825043
##########
cpp/src/arrow/record_batch.cc:
##########
@@ -167,30 +188,41 @@ class SimpleRecordBatch : public RecordBatch {
return RecordBatch::Validate();
}
+ std::shared_ptr<Device::SyncEvent> GetSyncEvent() const override { return
sync_event_; }
Review Comment:
In theory I can't think of one, but that doesn't mean there *can't* be a
situation like that.
But that's still a good point. I'd rather default to having it return `const
...&` for now, and update this in the future if necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
