felipecrv commented on code in PR #40807:
URL: https://github.com/apache/arrow/pull/40807#discussion_r1583832510
##########
cpp/src/arrow/record_batch.cc:
##########
@@ -664,7 +667,9 @@ Status RecordBatch::ValidateFull() const {
return ValidateBatch(*this, /*full_validation=*/true);
}
-const std::shared_ptr<Device::SyncEvent>& RecordBatch::GetSyncEvent() const {
return nullptr; }
+const std::shared_ptr<Device::SyncEvent>& RecordBatch::GetSyncEvent() const {
+ return nullptr;
Review Comment:
For this case, you should have a `null_sync_event_` member variable because
it's illegal to return a reference to a `std::shared_ptr<Device::SyncEvent>`
created on the stack implicitly from `nullptr`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
