alamb commented on code in PR #5727:
URL: https://github.com/apache/arrow-rs/pull/5727#discussion_r1591169135
##########
arrow-buffer/src/alloc/alignment.rs:
##########
@@ -80,15 +80,6 @@ pub const ALIGNMENT: usize = 1 << 5;
#[cfg(target_arch = "sparc64")]
pub const ALIGNMENT: usize = 1 << 6;
-// On ARM cache line sizes are fixed. both v6 and v7.
Review Comment:
This is removed because these `target_arch` apparently do not exist
```
warning: unexpected `cfg` condition value: `thumbv7`
--> arrow-buffer/src/alloc/alignment.rs:89:7
|
89 | #[cfg(target_arch = "thumbv7")]
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= note: expected values for `target_arch` are: `aarch64`, `arm`,
`arm64ec`, `avr`, `bpf`, `csky`, `hexagon`, `loongarch64`, `m68k`, `mips`,
`mips32r6`, `mips64`, `mips64r6`, `msp430`, `nvptx64`, `powerpc`, `powerpc64`,
`riscv32`, `riscv64`, `s390x`, `sparc`, `sparc64`, `wasm32`, `wasm64`, `x86`,
`x86_64`
= note: see
<https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg>
for more information about checking conditional configuration
```
##########
parquet/src/format.rs:
##########
@@ -5,7 +5,8 @@
#![allow(unused_imports)]
#![allow(unused_extern_crates)]
#![allow(clippy::too_many_arguments, clippy::type_complexity, clippy::vec_box,
clippy::wrong_self_convention)]
-#![cfg_attr(rustfmt, rustfmt_skip)]
+// Fix unexpected `cfg` condition name: `rustfmt`
https://github.com/apache/arrow-rs/issues/5725
+//#![cfg_attr(rustfmt, rustfmt_skip)]
Review Comment:
This was failing like
```
warning: unexpected `cfg` condition name: `rustfmt`
--> parquet/src/format.rs:8:13
|
8 | #![cfg_attr(rustfmt, rustfmt_skip)]
| ^^^^^^^
|
= help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`,
`doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`,
`relocation_model`, `sanitize`, `sanitizer_cfi_generalize_pointers`,
`sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`,
`target_endian`, `target_env`, `target_family`, `target_feature`,
`target_has_atomic`, `target_has_atomic_equal_alignment`,
`target_has_atomic_load_store`, `target_os`, `target_pointer_width`,
`target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, `windows`
= help: consider using a Cargo feature instead or adding
`println!("cargo::rustc-check-cfg=cfg(rustfmt)");` to the top of the `build.rs`
= note: see
<https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg>
for more information about checking conditional configuration
= note: `#[warn(unexpected_cfgs)]` on by default
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
