Jefffrey commented on code in PR #5727: URL: https://github.com/apache/arrow-rs/pull/5727#discussion_r1591601633
########## arrow-buffer/src/alloc/alignment.rs: ########## @@ -80,15 +80,6 @@ pub const ALIGNMENT: usize = 1 << 5; #[cfg(target_arch = "sparc64")] pub const ALIGNMENT: usize = 1 << 6; -// On ARM cache line sizes are fixed. both v6 and v7. Review Comment: This is interesting. I tried searching up to understand more but can't really find much to point towards existence of those `target_arch` values, even though targets like thumbv6m-none-eabi exist ########## parquet/src/format.rs: ########## @@ -5,7 +5,8 @@ #![allow(unused_imports)] #![allow(unused_extern_crates)] #![allow(clippy::too_many_arguments, clippy::type_complexity, clippy::vec_box, clippy::wrong_self_convention)] -#![cfg_attr(rustfmt, rustfmt_skip)] +// Fix unexpected `cfg` condition name: `rustfmt` https://github.com/apache/arrow-rs/issues/5725 +//#![cfg_attr(rustfmt, rustfmt_skip)] Review Comment: I think we can just remove this line if the permanent fix is the `#[rustfmt::skip]` in `parquet/src/lib.rs`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
