alamb commented on code in PR #5727: URL: https://github.com/apache/arrow-rs/pull/5727#discussion_r1592456629
########## parquet/src/format.rs: ########## @@ -5,7 +5,8 @@ #![allow(unused_imports)] #![allow(unused_extern_crates)] #![allow(clippy::too_many_arguments, clippy::type_complexity, clippy::vec_box, clippy::wrong_self_convention)] -#![cfg_attr(rustfmt, rustfmt_skip)] +// Fix unexpected `cfg` condition name: `rustfmt` https://github.com/apache/arrow-rs/issues/5725 +//#![cfg_attr(rustfmt, rustfmt_skip)] Review Comment: I was thinking it would be good to leave the comment explaining why the change as this file seems to be auto generated ```rust // Autogenerated by Thrift Compiler (0.19.0) // DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
