adamreeve commented on code in PR #41599:
URL: https://github.com/apache/arrow/pull/41599#discussion_r1596189468
##########
c_glib/arrow-glib/array-builder.cpp:
##########
@@ -231,8 +231,14 @@ garrow_array_builder_append_values(GArrowArrayBuilder
*builder,
if (n_remains > 0) {
++n_loops;
}
+#ifdef _MSVC_LANG
+ std::vector<uint8_t> data_vec(value_size * chunk_size);
+ uint8_t *data = data_vec.data();
Review Comment:
My understanding is that the variable length array approach would use stack
allocation so there might be a performance benefit over using `std::vector`,
but I'm happy to only use `std::vector` if you're not worried about that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
