adamreeve commented on code in PR #41599:
URL: https://github.com/apache/arrow/pull/41599#discussion_r1599269705
##########
.github/workflows/ruby.yml:
##########
@@ -305,3 +305,96 @@ jobs:
$Env:MAKE = "ridk exec make"
$ErrorActionPreference = "Continue"
rake -f ruby\Rakefile
+
+ windows-msvc:
+ name: AMD64 Windows MSVC GLib
+ runs-on: windows-2019
+ if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
+ timeout-minutes: 90
+ strategy:
+ fail-fast: false
+ env:
+ ARROW_BOOST_USE_SHARED: OFF
+ ARROW_BUILD_BENCHMARKS: OFF
+ ARROW_BUILD_SHARED: ON
+ ARROW_BUILD_STATIC: OFF
+ ARROW_BUILD_TESTS: OFF
+ ARROW_DATASET: OFF
+ ARROW_FLIGHT: OFF
+ ARROW_FLIGHT_SQL: OFF
+ ARROW_HDFS: OFF
+ ARROW_HOME: /usr
+ ARROW_JEMALLOC: OFF
+ ARROW_MIMALLOC: ON
+ ARROW_ORC: OFF
+ ARROW_PARQUET: OFF
+ ARROW_SUBSTRAIT: OFF
+ ARROW_USE_GLOG: OFF
+ ARROW_VERBOSE_THIRDPARTY_BUILD: OFF
+ ARROW_WITH_BROTLI: OFF
+ ARROW_WITH_BZ2: OFF
+ ARROW_WITH_LZ4: OFF
+ ARROW_WITH_OPENTELEMETRY: OFF
+ ARROW_WITH_SNAPPY: ON
+ ARROW_WITH_ZLIB: ON
+ ARROW_WITH_ZSTD: ON
+ BOOST_SOURCE: BUNDLED
+ CMAKE_CXX_STANDARD: "17"
+ CMAKE_GENERATOR: Ninja
+ CMAKE_INSTALL_LIBDIR: bin
+ CMAKE_INSTALL_PREFIX: /usr
+ CMAKE_UNITY_BUILD: ON
+ steps:
+ - name: Disable Crash Dialogs
+ run: |
+ reg add `
+ "HKCU\SOFTWARE\Microsoft\Windows\Windows Error Reporting" `
+ /v DontShowUI `
+ /t REG_DWORD `
+ /d 1 `
+ /f
+ - name: Checkout Arrow
+ uses: actions/checkout@v4
+ with:
+ fetch-depth: 0
+ submodules: recursive
+ - name: Install vcpkg
+ shell: bash
+ run: |
+ ci/scripts/install_vcpkg.sh ./vcpkg
+ - name: Install ccache
+ shell: bash
+ run: |
+ ci/scripts/install_ccache.sh 4.6.3 /usr
+ - name: Setup ccache
+ shell: bash
+ run: |
+ ci/scripts/ccache_setup.sh
+ - name: ccache info
+ id: ccache-info
+ shell: bash
+ run: |
+ echo "cache-dir=$(ccache --get-config cache_dir)" >> $GITHUB_OUTPUT
+ - name: Cache ccache
+ uses: actions/cache@v4
+ with:
+ path: ${{ steps.ccache-info.outputs.cache-dir }}
+ key: cglib-ccache-windows-${{ env.CACHE_VERSION }}-${{
hashFiles('cpp/**') }}
+ restore-keys: cglib-ccache-windows-${{ env.CACHE_VERSION }}-
+ env:
+ # We can invalidate the current cache by updating this.
+ CACHE_VERSION: "2024-05-09"
+ - name: Build
Review Comment:
I looked into this and got it working on another branch
(https://github.com/adamreeve/arrow/tree/msvc_glib_vcpkg), but it's quite slow
to build all the vcpkg dependencies (48 minutes on my GitHub actions run) and
this isn't integrated with ccache so will be slow every time. If you think it's
worth doing I can look at caching the vcpkg builds too? We do this in
ParquetSharp so it shouldn't be too hard to add:
https://github.com/G-Research/ParquetSharp/blob/ef8e7c447ecd5d84205eb73293162f5689e977b8/.github/workflows/ci.yml#L99-L118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
