adamreeve commented on code in PR #41599:
URL: https://github.com/apache/arrow/pull/41599#discussion_r1599263276
##########
c_glib/arrow-glib/array-builder.h:
##########
@@ -22,70 +22,97 @@
#include <arrow-glib/array.h>
#include <arrow-glib/decimal.h>
#include <arrow-glib/interval.h>
+#include <arrow-glib/visibility.h>
G_BEGIN_DECLS
#define GARROW_TYPE_ARRAY_BUILDER (garrow_array_builder_get_type())
+GARROW_EXPORT
G_DECLARE_DERIVABLE_TYPE(
GArrowArrayBuilder, garrow_array_builder, GARROW, ARRAY_BUILDER, GObject)
struct _GArrowArrayBuilderClass
{
GObjectClass parent_class;
};
+GARROW_EXPORT
GArrowDataType *
garrow_array_builder_get_value_data_type(GArrowArrayBuilder *builder);
+
+GARROW_EXPORT
GArrowType
garrow_array_builder_get_value_type(GArrowArrayBuilder *builder);
+GARROW_EXPORT
GArrowArray *
garrow_array_builder_finish(GArrowArrayBuilder *builder, GError **error);
GARROW_AVAILABLE_IN_2_0
+GARROW_EXPORT
Review Comment:
I've changed the macro definitions to only add dllimport/dllexport for MSVC
for now, so this works as currently only the arrow-glib library is built for
MSVC. But I can follow up to also add them under MinGW GCC later after adding
version macros per-library. Does that work for you or would you rather include
the per-library macros in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
