wgtmac commented on code in PR #41765:
URL: https://github.com/apache/arrow/pull/41765#discussion_r1609163195
##########
cpp/src/parquet/types.cc:
##########
@@ -464,7 +464,10 @@ std::shared_ptr<const LogicalType> LogicalType::FromThrift(
} else if (type.__isset.FLOAT16) {
return Float16LogicalType::Make();
} else {
- throw ParquetException("Metadata contains Thrift LogicalType that is not
recognized");
+ // Or provide some mechanism to optionally error here?
Review Comment:
I agree that we might need an option to make it throw or ignore for unknown
logical type.
BTW, it seems that parquet-java also fails on unknown type:
https://github.com/apache/parquet-java/blob/6809a18597e56709696af58313343aeea93f0b99/parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java#L1142-L1179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
