wgtmac commented on code in PR #41765:
URL: https://github.com/apache/arrow/pull/41765#discussion_r1618083421
##########
cpp/src/parquet/types.cc:
##########
@@ -464,7 +464,10 @@ std::shared_ptr<const LogicalType> LogicalType::FromThrift(
} else if (type.__isset.FLOAT16) {
return Float16LogicalType::Make();
} else {
- throw ParquetException("Metadata contains Thrift LogicalType that is not
recognized");
+ // Or provide some mechanism to optionally error here?
Review Comment:
https://github.com/apache/arrow/blob/13630c7a8316bccce4a119d193e3a46f5a9a35bc/cpp/src/parquet/metadata.cc#L1920
You might need to hack the thrift object directly from `metadata_->schema`
above by setting an unknown logical value. This means we have to create a
parquet file any way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
