pitrou commented on code in PR #41822:
URL: https://github.com/apache/arrow/pull/41822#discussion_r1617537030
##########
cpp/src/arrow/filesystem/s3fs.cc:
##########
@@ -2871,6 +2872,12 @@ Status S3FileSystem::CreateDir(const std::string& s,
bool recursive) {
for (const auto& part : path.key_parts) {
parent_key += part;
parent_key += kSep;
+ if (options().check_directory_existence_before_creation) {
Review Comment:
I'm curious, don't you want to do the checks by walking up instead of
walking down?
For example, when `CreateDir("a/b/c")` is called, it would seem more logical
to first check for `a/b/c`'s existence, then `a/b` if it doesn't exist, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
