HaochengLIU commented on code in PR #41822:
URL: https://github.com/apache/arrow/pull/41822#discussion_r1618076288
##########
cpp/src/arrow/filesystem/s3fs.cc:
##########
@@ -2871,6 +2872,12 @@ Status S3FileSystem::CreateDir(const std::string& s,
bool recursive) {
for (const auto& part : path.key_parts) {
parent_key += part;
parent_key += kSep;
+ if (options().check_directory_existence_before_creation) {
Review Comment:
~~I just reflect on it and my 2cents is to keep the walking down logic. I'm
doing the checking inside the creation step. I can only build a wall from the
bottom up otherwise the world is upside down :) So I must check `a` then `a/b`
and `a/b/c`.~~
let me think about it again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
