HaochengLIU commented on code in PR #41822:
URL: https://github.com/apache/arrow/pull/41822#discussion_r1625105223


##########
cpp/src/arrow/filesystem/s3fs_test.cc:
##########
@@ -922,9 +922,13 @@ TEST_F(TestS3FS, CreateDir) {
 
   // New "directory"
   AssertFileInfo(fs_.get(), "bucket/newdir", FileType::NotFound);
-  ASSERT_OK(fs_->CreateDir("bucket/newdir"));
+  ASSERT_OK(fs_->CreateDir("bucket/newdir", false));

Review Comment:
   I realize 
[CreateDir](https://github.com/apache/arrow/blob/main/cpp/src/arrow/filesystem/filesystem.h#L240)
 defaults to recursive mode. Thus here I'm extending s3fs_test.cc to cover this 
untested scenario.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to