paleolimbot opened a new pull request, #1891: URL: https://github.com/apache/arrow-adbc/pull/1891
I'd been using `-DADBC_EXPORT=""` to work around this in the R package: I think that the `_WIN32` guard in the ADBC header resulted in `__declspec(dllexport/import)` ending up in gcc on mys2 which resulted in a compiler error. I think that `_MSC_VER` is the right thing to check here but I am not all that familiar with the details of this works on Windows (although I am perhaps about to be: https://github.com/apache/arrow-nanoarrow/issues/495 ). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
