kou commented on code in PR #1891:
URL: https://github.com/apache/arrow-adbc/pull/1891#discussion_r1618211786
##########
adbc.h:
##########
@@ -152,15 +152,15 @@ struct ArrowArrayStream {
// Storage class macros for Windows
// Allow overriding/aliasing with application-defined macros
#if !defined(ADBC_EXPORT)
-#if defined(_WIN32)
+#if defined(_MSC_VER)
Review Comment:
We need to use `_WIN32` not `_MSC_VER` here because MinGW doesn't define
`_MSC_VER` but it requires `__delcspec(...)`. `_WIN32` is defined on both of
MinGW and MSVC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
