paleolimbot commented on PR #1891: URL: https://github.com/apache/arrow-adbc/pull/1891#issuecomment-2137376891
> We need to use _WIN32 not _MSC_VER here because MinGW doesn't define _MSC_VER but it requires __delcspec(...). _WIN32 is defined on both of MinGW and MSVC. Thanks! I'm very new to this aspect of library development 😬 In revisiting why the R packages fail to build here, it's that if we don't define `ADBC_EXPORTING`, we get the dllimport attribute, which for the R packages is not correct because we're not linking to a DLL (we're building all the symbols into our own .dll, *not* exporting them if possible, and exposing the ones we do want by wrapping them in an R function or using an R-level external pointer. So, I think that `-DADBC_EXPORT=""` is actually correct here (we are neither importing nor exporting). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
