laurentgo commented on code in PR #41825:
URL: https://github.com/apache/arrow/pull/41825#discussion_r1618581614
##########
java/algorithm/pom.xml:
##########
@@ -48,5 +52,87 @@
</dependency>
</dependencies>
- <build></build>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-checkstyle-plugin</artifactId>
+ <version>3.1.0</version>
+ <configuration>
+ <skip>true</skip>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
+
+ <profiles>
+ <profile>
+ <id>spotless</id>
+ <activation>
+ <activeByDefault>true</activeByDefault>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>com.diffplug.spotless</groupId>
+ <artifactId>spotless-maven-plugin</artifactId>
+ <version>${spotless.version}</version>
+ <configuration>
+ <formats>
+ <format>
Review Comment:
Sorry, I should have been clearer. What I meant is that you could use those
instead:
```
<java>
<googleJavaFormat>
<version>1.7</version>
<style>GOOGLE</style>
</googleJavaFormat>
<licenseHeader>
<file>../dev/license/asf-java.license</file>
<delimiter>package</delimiter>
</licenseHeader>
</java>
```
and
```
<pom>
<sortPom></sortPom>
<licenseHeader>
<file>../dev/license/asf-xml.license</file>
<delimiter>(<configuration|<project)</delimiter>
</licenseHeader>
</pom>
```
That said, I also noticed by checking the change locally that the path to
the license file is relative to the root of the module, which may cause extra
issues (something that `maven-checkstyle-plugin` does support although not
quite [documented](https://issues.apache.org/jira/browse/MCHECKSTYLE-131)). We
may need to use `${maven.multiModuleProjectDirectory}` property (although not
offically supported) or a plugin to compute the right path
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
