vibhatha commented on code in PR #41825:
URL: https://github.com/apache/arrow/pull/41825#discussion_r1619580034
##########
java/algorithm/pom.xml:
##########
@@ -48,5 +52,87 @@
</dependency>
</dependencies>
- <build></build>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-checkstyle-plugin</artifactId>
+ <version>3.1.0</version>
+ <configuration>
+ <skip>true</skip>
Review Comment:
@laurentgo @lidavidm I observed the following when I re-enabled check-style
for the algorithm module;
1. EmptyLineSeparator (whitespace)
2. ImportOrder (imports)
3. OperatorWrap (whitespace)
4. RightCurly (blocks)
5. SingleLineJavadoc (javadoc)
6. Indentation (indentation)
I observed the above warnings and ultimately the build fails. I think as
both of you suggested we should list checkstyle features we want to keep. But
it seems these are in collision course with what spotless is doing.
I can suggest the following;
Create a new issue for the graceful update of checkstyle features while
working per module. But while working on spotless addition per module, we can
disable checkstyle for the moment, but in that separate follow up issue, we
remove the colliding checkstyle features and remove checkstyle-disable from
each module.
Appreciate your thoughts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
