vibhatha commented on code in PR #41825:
URL: https://github.com/apache/arrow/pull/41825#discussion_r1619587755
##########
java/algorithm/pom.xml:
##########
@@ -48,5 +52,87 @@
</dependency>
</dependencies>
- <build></build>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-checkstyle-plugin</artifactId>
+ <version>3.1.0</version>
+ <configuration>
+ <skip>true</skip>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
+
+ <profiles>
+ <profile>
+ <id>spotless</id>
+ <activation>
+ <activeByDefault>true</activeByDefault>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>com.diffplug.spotless</groupId>
+ <artifactId>spotless-maven-plugin</artifactId>
+ <version>${spotless.version}</version>
+ <configuration>
+ <formats>
+ <format>
Review Comment:
@laurentgo I updated,
I used the `{project.basedir}` attribute which gives the path to the current
module (the pom's module path). Also for the moment, I kept the pom and java
license stuff to the algorithm pom itself. The best thing is to move this to
the parent, but it formats so many other files in other modules which we want
to avoid in this modular approach we are taking. We can create an additional
issue to gracefully clean things up once we have updated all modules so the
diffs in each PR is manageable for review purpose. Hope this is okay
:slightly_smiling_face:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
