pitrou commented on code in PR #41822:
URL: https://github.com/apache/arrow/pull/41822#discussion_r1625945190
##########
cpp/src/arrow/filesystem/s3fs_test.cc:
##########
@@ -939,6 +943,31 @@ TEST_F(TestS3FS, CreateDir) {
// Extraneous slashes
ASSERT_RAISES(Invalid, fs_->CreateDir("bucket//somedir"));
ASSERT_RAISES(Invalid, fs_->CreateDir("bucket/somedir//newdir"));
+
+ // check existing before creation
+ options_.check_directory_existence_before_creation = true;
+ MakeFileSystem();
+ /// New "directory" again
+ AssertFileInfo(fs_.get(), "bucket/checknewdir", FileType::NotFound);
+ ASSERT_OK(fs_->CreateDir("bucket/checknewdir"));
+ AssertFileInfo(fs_.get(), "bucket/checknewdir", FileType::Directory);
+
+ ASSERT_RAISES(IOError,
fs_->CreateDir("bucket/checknewdir/newsub/newsubsub/newsubsub/",
+ /*recursive=*/false));
+
+ /// New "directory" again, recursive
+ ASSERT_OK(fs_->CreateDir("bucket/checknewdir/newsub/newsubsub",
/*recursive=*/true));
+ AssertFileInfo(fs_.get(), "bucket/checknewdir/newsub", FileType::Directory);
+ AssertFileInfo(fs_.get(), "bucket/checknewdir/newsub/newsubsub",
FileType::Directory);
+ AssertFileInfo(fs_.get(), "bucket/checknewdir/newsub/newsubsub/newsubsub",
+ FileType::NotFound);
+ //// Try creation with the same name
Review Comment:
```suggestion
// Try creation with the same name
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
