felipecrv commented on code in PR #41995:
URL: https://github.com/apache/arrow/pull/41995#discussion_r1628547283
##########
cpp/src/arrow/compute/kernel.cc:
##########
@@ -411,21 +409,23 @@ bool InputType::Matches(const DataType& type) const {
return type_->Equals(type);
case InputType::USE_TYPE_MATCHER:
return type_matcher_->Matches(type);
- default:
- // ANY_TYPE
- return true;
+ case InputType::ANY_TYPE:
+ break;
}
+ return true;
Review Comment:
This means that if `kind_` is poisoned memory, we return `true` instead of
poison (true or false non-deterministically). Making the code identical to the
previous version but without the `default` case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
