felipecrv commented on code in PR #41995:
URL: https://github.com/apache/arrow/pull/41995#discussion_r1628639337
##########
cpp/src/arrow/compute/kernel.cc:
##########
@@ -400,9 +399,8 @@ bool InputType::Equals(const InputType& other) const {
return type_->Equals(*other.type_);
case InputType::USE_TYPE_MATCHER:
return type_matcher_->Equals(*other.type_matcher_);
- default:
- return false;
}
+ return false;
Review Comment:
It might be reached if `kind_` is bogus memory. I could remove this line
altogether and let poison (true/false randomly) be returned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
