felipecrv commented on code in PR #41995:
URL: https://github.com/apache/arrow/pull/41995#discussion_r1628664156
##########
cpp/src/arrow/compute/kernel.cc:
##########
@@ -445,11 +445,13 @@ const TypeMatcher& InputType::type_matcher() const {
Result<TypeHolder> OutputType::Resolve(KernelContext* ctx,
const std::vector<TypeHolder>& types)
const {
- if (kind_ == OutputType::FIXED) {
- return type_.get();
- } else {
- return resolver_(ctx, types);
+ switch (kind_) {
+ case OutputType::FIXED:
+ return type_;
+ case OutputType::COMPUTED:
+ break;
}
+ return resolver_(ctx, types);
Review Comment:
Overkill. That `return Status` would only ever be reached if `kind_` is
poisoned memory: in that case all that we need is consistent behavior to not go
crazy debugging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
