WillAyd commented on code in PR #517:
URL: https://github.com/apache/arrow-nanoarrow/pull/517#discussion_r1633832561
##########
CMakeLists.txt:
##########
@@ -493,6 +606,55 @@ if(NANOARROW_BUILD_TESTS)
gtest_discover_tests(nanoarrow_ipc_files_test)
gtest_discover_tests(nanoarrow_ipc_hpp_test)
endif()
+
+ if(NANOARROW_DEVICE)
+ enable_testing()
Review Comment:
There are a few things here that are duplicative of what happens in the IPC
branch directly preceding it, but didn't try to solve that as part of this PR.
Figured a copy/paste from the old structure into the new would be easiest to
review
##########
CMakeLists.txt:
##########
@@ -16,7 +16,7 @@
# under the License.
message(STATUS "Building using CMake version: ${CMAKE_VERSION}")
-cmake_minimum_required(VERSION 3.14)
+cmake_minimum_required(VERSION 3.22)
Review Comment:
The version bump is required to support the DEPENDS condition in the
dependent option:
https://cmake.org/cmake/help/v3.29/module/CMakeDependentOption.html
Might be a creative way to work around this if 3.14 is a hard requirement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
