WillAyd commented on code in PR #517: URL: https://github.com/apache/arrow-nanoarrow/pull/517#discussion_r1635142169
########## CMakeLists.txt: ########## @@ -73,7 +92,8 @@ endif() configure_file(src/nanoarrow/nanoarrow_config.h.in generated/nanoarrow_config.h) -if(NANOARROW_IPC AND (NANOARROW_BUILD_TESTS OR NOT NANOARROW_BUNDLE)) +if((NANOARROW_DEVICE OR NANOARROW_IPC) AND (NANOARROW_BUILD_TESTS OR NOT NANOARROW_BUNDLE + )) Review Comment: I actually think it was a mistake to include NANOARROW_DEVICE here - the nanoarrow_device target on main includes the flatcc headers as part of the build interface but I don't think actually requires it. Just removed that instead to keep this section untouched -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
