paleolimbot commented on code in PR #517:
URL: https://github.com/apache/arrow-nanoarrow/pull/517#discussion_r1634849426
##########
CMakeLists.txt:
##########
@@ -73,7 +92,8 @@ endif()
configure_file(src/nanoarrow/nanoarrow_config.h.in
generated/nanoarrow_config.h)
-if(NANOARROW_IPC AND (NANOARROW_BUILD_TESTS OR NOT NANOARROW_BUNDLE))
+if((NANOARROW_DEVICE OR NANOARROW_IPC) AND (NANOARROW_BUILD_TESTS OR NOT
NANOARROW_BUNDLE
+ ))
Review Comment:
Maybe wrap the flatcc bit with `if(NANOARROW_IPC)` so that it doesn't get
run if we're only building with `NANOARROW_DEVICE`?
##########
CMakeLists.txt:
##########
@@ -16,7 +16,7 @@
# under the License.
message(STATUS "Building using CMake version: ${CMAKE_VERSION}")
-cmake_minimum_required(VERSION 3.14)
+cmake_minimum_required(VERSION 3.22)
Review Comment:
I believe 3.14 comes from centos7's `cmake3`. I think for now you can just
ignore the option dependencies...I am doing an overhaul of the device code in
the next few weeks and I'm not sure exactly what the final CMake options will
be.
##########
docs/source/conf.py:
##########
@@ -66,8 +66,6 @@ def get_version():
# Breathe configuration
breathe_projects = {
Review Comment:
The place where this shows up is:
https://arrow.apache.org/nanoarrow/latest/reference/device.html
...and I think that a few lines of
https://github.com/apache/arrow-nanoarrow/blob/ec1a6927283a33a97232047179b6abc77c374de3/docs/source/reference/device.rst#L24-L41
and
https://github.com/apache/arrow-nanoarrow/blob/main/docs/source/reference/ipc.rst?plain=1#L24-L33
...might need to be updated (the new project would just be `nanoarrow_c`).
##########
README.md:
##########
@@ -132,3 +132,53 @@ meson test nanoarrow: # default test run
meson test nanoarrow: --wrap valgrind # run tests under valgrind
meson test nanoarrow: --benchmark --verbose # run benchmarks
```
+
+# nanoarrow device option
Review Comment:
This will need updating shortly, so I pasted it into
https://github.com/apache/arrow-nanoarrow/issues/497#issuecomment-2160718697
and I think it might be better to leave it out for now (until the device
behaviour has converged).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
