felipecrv commented on code in PR #42108:
URL: https://github.com/apache/arrow/pull/42108#discussion_r1637302122
##########
cpp/src/arrow/filesystem/azurefs.cc:
##########
@@ -418,6 +418,9 @@ AzureOptions::MakeDataLakeServiceClient() const {
Result<std::string> AzureOptions::GenerateSASToken(
Storage::Sas::BlobSasBuilder* builder, Blobs::BlobServiceClient* client)
const {
+ using SasProtocol = Storage::Sas::SasProtocol;
+ builder->Protocol =
+ blob_storage_scheme == "http" ? SasProtocol::HttpsAndHttp :
SasProtocol::HttpsOnly;
Review Comment:
Falling back to the secure protocol is not so bad and we ensure it's valid
when constructing from URI.
https://github.com/apache/arrow/blob/512d2458ff777f15354ee2a88bde7723ec3d5035/cpp/src/arrow/filesystem/azurefs.cc#L139-L145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
