pitrou commented on code in PR #42108:
URL: https://github.com/apache/arrow/pull/42108#discussion_r1637767723
##########
cpp/src/arrow/filesystem/azurefs.cc:
##########
@@ -418,6 +418,9 @@ AzureOptions::MakeDataLakeServiceClient() const {
Result<std::string> AzureOptions::GenerateSASToken(
Storage::Sas::BlobSasBuilder* builder, Blobs::BlobServiceClient* client)
const {
+ using SasProtocol = Storage::Sas::SasProtocol;
+ builder->Protocol =
+ blob_storage_scheme == "http" ? SasProtocol::HttpsAndHttp :
SasProtocol::HttpsOnly;
Review Comment:
Passing an unsupported scheme should be a user error, since filesystem
configuration is typically chosen by the user. It doesn't really help the user
to allow incorrect values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
